Direct emissions chart and dashboard items using new mapping setup#3460
Open
kndehaan wants to merge 24 commits into
Open
Direct emissions chart and dashboard items using new mapping setup#3460kndehaan wants to merge 24 commits into
kndehaan wants to merge 24 commits into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a renewed PR that adds the queries for a direct emisisons chart and two dashboard items, using the mapping config implementation. This PR replaces the former PR #3449 that used the old setup, which is therefore closed.
Only the queries have to be reviewed. File changes related to the new mapping setup (add sector label, mapping file, spec) are addressed in a separate PR #3459, which is currently in draft.
Implemented changes
Remarks:
direct_emissions_bunkers_co2_1990needs to be updated with the new mapping setup once the bug mentioned in Add sector mapping CSV,sector_label/userollout, and validation #3459 (comment) has been resolved. The value result will remain the same.Related
Goes with pull requests:
emissions-mappingemissions-mappingemissions-user-output-mappingemissions-user-input-outputemissions-user-input-outputemissions-user-input-outputChecklist