Skip to content

[core] Avoid GCS crash on Redis connection loss in RedisResponseFn #64204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadongjun wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

[core] Avoid GCS crash on Redis connection loss in RedisResponseFn #64204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bafecfc
[core] Avoid GCS crash on Redis connection loss in RedisResponseFn
nadongjun Jun 18, 2026
4b6b8a8
Merge branch 'master' into fix/gcs-redis-reconnect-on-failover
nadongjun Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ray/gcs/store_client/redis_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ void RedisRequestContext::RedisResponseFn(redisAsyncContext *async_context,
auto redis_reply = reinterpret_cast<redisReply *>(raw_reply);
// Error happened.
if (redis_reply == nullptr || redis_reply->type == REDIS_REPLY_ERROR) {
auto error_msg = redis_reply ? redis_reply->str : async_context->errstr;
auto error_msg = redis_reply ? redis_reply->str
: (async_context ? async_context->errstr
: "Redis connection unavailable");
RAY_LOG(ERROR) << "Redis request [" << absl::StrJoin(request_cxt->redis_cmds_, " ")
<< "]"
<< " failed due to error " << error_msg << ". "
Expand Down
Loading