pax: truncate long names on a UTF-8 char boundary#617
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #616.
pax -wpanics when a filename longer than 100 bytes has a multi-byte UTF-8 character straddling the 100-byte ustarnameboundary, becausesplit_pathsliced the path withpath_str[..NAME_LEN]on a byte index that is not a char boundary.The truncation is only the ustar fallback (the full path is preserved in the extended header), so this truncates at the largest char boundary at or below
NAME_LENinstead. Added a regression test that reproduces the panic from the issue ('a' + 'Я'*90).