/speakers/for_backloadedhorn の section 見出しを実態に合わせて i18n 対応で修正#5
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agent-Logs-Url: https://github.com/sakadon/digitalsignagerjp/sessions/ad4ea904-336e-4919-803e-3c04335007b9 Co-authored-by: sakadon <3520192+sakadon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sakadon/digitalsignagerjp/sessions/ad4ea904-336e-4919-803e-3c04335007b9 Co-authored-by: sakadon <3520192+sakadon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update section title for speakers page
/speakers/for_backloadedhorn の section 見出しを実態に合わせて i18n 対応で修正
May 12, 2026
sakadon
marked this pull request as ready for review
May 12, 2026 18:33
There was a problem hiding this comment.
Pull request overview
/speakers/for_backloadedhorn の見出し文言を実態(Qtsの低い順)に合わせ、既存の i18n 構成(next-translate)に沿って翻訳キー化するPRです。
Changes:
/speakers/for_backloadedhornの見出し表示を翻訳キー参照に変更speakers_dir.for_backloadedhorn.section_headingを英語・日本語の辞書に追加
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pages/speakers/for_backloadedhorn.js | セクション見出しを i18n キー参照に置き換え |
| locales/ja/common.js | speakers_dir.for_backloadedhorn.section_heading を追加 |
| locales/en/common.js | speakers_dir.for_backloadedhorn.section_heading を追加 |
Comment on lines
78
to
80
| <h3 className="mb-4 text-4xl font-bold text-blue-900 text-center"> | ||
| Qts (Q0): {group.Qts} | ||
| {t('speakers_dir.for_backloadedhorn.section_heading')} | ||
| </h3> |
| @@ -76,7 +76,7 @@ export default function GroupedByCategories({ speakers }) { | |||
| {groupedSpeakers.map((group, groupIndex) => ( | |||
| <div key={groupIndex} id={group.category} className="rounded-lg bg-gray-100 py-5 px-3 mb-10"> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/speakers/for_backloadedhornの section 見出しがQts (Q0): Infinityと表示され、実際の並び順(Qts の低い順)と意味がずれていました。見出しを実態に合う表現へ変更し、既存の多言語構成に合わせて翻訳キー化しています。見出し表示の修正(ページ)
pages/speakers/for_backloadedhorn.jsの section 見出しを、値表示ベースの文言から意味ベースの文言に変更useTranslation経由のキー参照へ置き換え翻訳キー追加(英語/日本語)
locales/en/common.jsにspeakers_dir.for_backloadedhorn.section_headingを追加Sorted by Qts (lowest first)locales/ja/common.jsに同キーを追加Qtsの低い順Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost(dns block)static.hotjar.com/home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost(dns block)va.vercel-scripts.com/home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost(dns block)If you need me to access, download, or install something from one of these locations, you can either: