Fix empty error object logged for AWS location healthcheck failures#6196
Open
maeldonn wants to merge 2 commits into
Open
Fix empty error object logged for AWS location healthcheck failures#6196maeldonn wants to merge 2 commits into
maeldonn wants to merge 2 commits into
Conversation
AWS SDK throws S3ServiceException, whose inherited Error fields
(message, name, stack) are non-enumerable and dropped by JSON.stringify,
so failures surfaced as "error":{} in startup logs. Normalize Error
instances in per-location healthcheck results into plain objects so
message, name, and AWS SDK $metadata survive serialization.
Issue: CLDSRV-933
Contributor
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.4 #6196 +/- ##
===================================================
+ Coverage 85.44% 85.49% +0.04%
===================================================
Files 209 209
Lines 14221 14226 +5
===================================================
+ Hits 12151 12162 +11
+ Misses 2070 2064 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS SDK throws S3ServiceException, whose inherited Error fields (message, name, stack) are non-enumerable and dropped by JSON.stringify, so failures surfaced as "error":{} in startup logs. Normalize Error instances in per-location healthcheck results into plain objects so message, name, and AWS SDK $metadata survive serialization.
Issue: CLDSRV-933