Skip to content

perf: don't apply fancy indexing if split can be a slice. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
selmanozleyen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

perf: don't apply fancy indexing if split can be a slice. #235

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4414378
init
selmanozleyen Jun 15, 2026
b32c2c9
add one more condition to shortcircuit
selmanozleyen Jun 15, 2026
ed13ead
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 15, 2026
d520726
Merge branch 'main' into perf/dont-apply-fancy-indexing-if-not-needed
selmanozleyen Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/annbatch/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,11 @@ def __iter__(
in_memory_indices: None | np.ndarray = self._maybe_accumulate_indices(dataset_index_to_rows)
for split in splits:
sel = inv[split]

# Use basic slicing for contiguous selections to avoid costly fancy indexing on the loaded memory
if len(sel) > 0 and (sel[-1] - sel[0] == len(sel) - 1 and np.all(np.diff(sel) == 1)):
sel = slice(sel[0], sel[-1] + 1)

data = in_memory_data[sel]
yield {
"X": data if not self._to_torch else to_torch(data, self._preload_to_gpu),
Expand Down
Loading