Improvements#35
Open
skoef wants to merge 12 commits into
Open
Conversation
The file handler was never closed after writing config file
Command output was shown as bytes instead of a string and include stderr in the output as well
strings.Fields does a better job than strings.Split
When something goes wrong closing the config file handler, return the error
Any read error on either file was treated as "files differ", so os.Rename proceeded
When the status channel was delayed for some reason, the whole actions loop would block
If every reload times out, reloadedBefore stays false forever. Every subsequent action with an identical config bypasses the "already reloaded" guard and fires another reload, which also times out, looping endlessly
and fix linting new issues that came up with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have Claude work with me to improve the software a bit: