compiler: Support animations on global properties in LLR#11944
Open
ImFeH2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before,
remove_aliasesmove animation from an alias property to the global property it aliases. The interpreter already handled that, but the LLR/codegen path still assumed that global properties don't have animations, which caused a panic.This keeps the animation on the lowered
GlobalComponentand expose it throughproperty_info(), so generated setters can still useset_animated_value(). Theremove_unusedpass andpretty_printernow handle the animation map as well.Fixes: #9961
The repro case compiled as a Rust app now matches the viewer behavior: the global property update animates instead of panicking.