feat markdown rich - #12664
Conversation
…k enum Introduce a ParagraphBlock enum to carry block-level metadata (heading level, horizontal rule) instead of adding optional fields to the old flat struct. A shared RichText struct captures the inline-content pattern for text and heading blocks. Add parser support for headings and horizontal rules.
c361813 to
dcd0a81
Compare
39b6719 to
9236981
Compare
38a8835 to
f9712b5
Compare
tronical
left a comment
There was a problem hiding this comment.
Thanks! The breakdown of the series looks overall quite reasonable. I'd very much appreciate though if you could also break it down in PRs. So just take the first refactoring and make a PR. Then we review it and get it in, then we continue from there. We're reviewing this code as humans :)
|
Thanks @tronical. I will cleanup and split into another PR before moving out of draft.
Also, I'll be interested in knowing if the larger opinion is to skip these concerns and push a lean PR which only implements few text formatting elements. |
I suggest that we can fine-tune the style when we get to the PRs that implement style. They should come with screenshot tests, so that we can "lock" in the rendering.0
I don't see us moving to cosmic-text. I suggest to leave out superscript and subscript for now. Perhaps that could be implemented in parley first?
I'd say let's cross that bridge when we get to that PR. Each increment of better rich text support provides value as-is, and if one particular feature takes longer than another then that's fine.
I suggest to start with the basis, adjusting the data structures, then perhaps headings as a start, and then take it from there. I suggest to use a tracking issue (that you can also edit as you like) so that we can all see what has landed and what's still missing. |
fixes #12648
How it looks at present:

