Fixed animation reset bug - #12683
Open
R-Cramer4 wants to merge 2 commits into
Open
Conversation
- If a binding's dependencies changed it would cause the animation to restart even if it didn't update the animation target
R-Cramer4
force-pushed
the
kms-animation-fix
branch
from
July 31, 2026 12:25
feef706 to
51ee97c
Compare
tronical
reviewed
Aug 4, 2026
tronical
left a comment
Member
There was a problem hiding this comment.
Looks generally good. This seems sensible behaviour.
R-Cramer4
force-pushed
the
kms-animation-fix
branch
from
August 5, 2026 14:28
3a13f3f to
4444200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An animation could be reset or not run if the dependencies of a binding are changed without actually changing the animation values. This is most notable on embedded hardware as you can force things to change at the frame rate therefore pausing the animation. On desktop it is noticeable as a jitter, and a reproducible example is:
AppWindow.slint
main.rs: