git ignore: CMakePreset generates different build dir. Excludes all build* builddir - #12729
Open
Montel wants to merge 1 commit into
Open
git ignore: CMakePreset generates different build dir. Excludes all build* builddir#12729Montel wants to merge 1 commit into
Montel wants to merge 1 commit into
Conversation
Member
|
Can you elaborate how you get extra build dir? |
Contributor
Author
|
cmake --preset debug-mold for example :) |
tronical
requested changes
Jul 31, 2026
tronical
left a comment
tronical
left a comment
Member
There was a problem hiding this comment.
I don't like the idea of excluding build*. I'd very much prefer to exclude the build directories that cmake creates for the presents we have listed in CMakePresets.json
Montel
force-pushed
the
fix_ignore_build_dir
branch
from
July 31, 2026 14:48
b7211aa to
af3ad69
Compare
tronical
reviewed
Jul 31, 2026
tronical
left a comment
tronical
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Now just the commit message needs adjusting, I think, as it refers to excluding all build*.
Montel
force-pushed
the
fix_ignore_build_dir
branch
from
July 31, 2026 14:56
af3ad69 to
07d142e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.