-
-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Asynchronous pipeline creation #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
43b4724
Implement initAsync
aleksanderkatan e5168a6
Add tests
aleksanderkatan 11607d8
Abstract PerformanceCollector from unwrap
aleksanderkatan c352876
Abstract `resolveAndCreateShaderModule`
aleksanderkatan 8852e65
Clean up initAsync
aleksanderkatan fcbed03
Add jsDocs
aleksanderkatan fa5c706
Extract unwrap to initSync
aleksanderkatan 3f4379d
Add initSync to the interface
aleksanderkatan 674c6b2
Update examples
aleksanderkatan 32c9d16
Update docs
aleksanderkatan e3ee140
Update examples
aleksanderkatan af270ae
Rename PerformanceCollector to PerformanceTracker
aleksanderkatan de777f1
Use true private props
aleksanderkatan a5f7a10
Add initAsync and initSync directly onto guarded compute pipeline
aleksanderkatan 5dc41cb
Update docs
aleksanderkatan f090a7a
Await promises in examples as late as possible
aleksanderkatan 0aa4ef3
Move cleanup to finally
aleksanderkatan 8d56157
Update docs
aleksanderkatan 22cffdd
Update interfaces
aleksanderkatan 9f6bee0
Add guarded compute pipeline tests
aleksanderkatan d6ca5ec
Add render pipeline tests
aleksanderkatan f8b309d
Move performance tracker to another file
aleksanderkatan 51ec842
Use performance tracker in render pipeline
aleksanderkatan abda3fa
Separate unwrap logic to resolveAndCreateShaderModule
aleksanderkatan aa2ad94
Add initSync and initAsync implementations
aleksanderkatan 507064d
Add render pipeline initialization to examples
aleksanderkatan 2e3293a
Update expected calls and snapshots
aleksanderkatan 1caa389
Merge remote-tracking branch 'origin/main' into feat/asynchronous-pip…
aleksanderkatan aca8bfb
Review fixes
aleksanderkatan 858e21a
nr fix
aleksanderkatan 4efe6ad
Fix lines combinations expected calls
aleksanderkatan 9b0adbb
Fix js doc
aleksanderkatan 0a8a1e9
Add initSync and initAsync to runners, update radiance cascades example
aleksanderkatan 39a1e14
Revert example changes
aleksanderkatan c1cd579
Merge remote-tracking branch 'origin/main' into feat/asynchronous-pip…
aleksanderkatan 2f066ba
Add jsDoc
aleksanderkatan 00d542d
Merge remote-tracking branch 'origin/main' into feat/asynchronous-pip…
aleksanderkatan 23ae40a
Merge remote-tracking branch 'origin/main' into feat/asynchronous-pip…
aleksanderkatan a5fcf15
Import from 'typegpu'
aleksanderkatan f3384dd
Merge branch 'main' into feat/asynchronous-pipeline-creation
aleksanderkatan 1a6ad09
Merge branch 'main' into feat/asynchronous-pipeline-creation
aleksanderkatan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the explanation of when one should use
initSyncas opposed toinitAsyncand vice versa. On the other hand, it's non-trivial to explain it briefly 🤔Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this paragraph and added commented snippets, tell me what you think