Add search box to CardSelect#4
Merged
Merged
Conversation
* Use autoFocus prop instead of ref * Display subheaders in search results * Show no results placeholder * Add icon and placeholder to input
Owner
|
Hey @T3nak, thanks a lot for your contribution, and sorry for the delayed response. I was pretty busy at the start of the year, and your PR unfortunately slipped through the cracks. Adding search to the card drawer is a great idea. I've just pushed a few minor tweaks to build on your work and will release this change soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for providing this scoring app!
CardSelectthat allows you to type to search through available cards.CardDraweropens.Disclaimer: I don't have experience with React