Add theme select to CreateGameView header#6
Merged
Conversation
Owner
|
Great idea. I didn’t realize Joy UI supported this out of the box. I made a small UX tweak by replacing the dropdown with a toggle button and persisting the selection in local storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything was already set up with Joy UI to allow switching between light and dark theme modes. This PR just adds a select box to the header of the
GameCreateViewthat lets the user switch their theme mode.Please note that translations were added and I do not know what your process is for ensuring accurate translations.
Disclaimer: I don't have experience with React