[6.x] Improve recursive behavior when using route data in computed values#11855
Merged
jasonvarga merged 4 commits intoJul 10, 2026
Merged
Conversation
edalzell
reviewed
Jun 9, 2025
duncanmcclean
changed the title
…cursion-when # Conflicts: # tests/Data/Entries/EntryTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #11853. When a computed value triggers the
routeDatamethod and the collection has a structure, you can end up in an infinite loop when fetching the entry.This PR wraps computed values in a
Valueobject to defer their execution only when resolvingrouteData. This is accomplished with two new methods:getComputedDatagetValuesBoth of these methods allow the caller to wrap computed callbacks in a
Valueobject. These methods are now used in the existingcomputedDataandvaluesmethods. This was done to keep the signatures of these methods the same.It will still be possible to cause infinite loops, depending on what the user is doing. The changes in #11854 will help with those scenarios.