Add missing identity to Heartbeat RPC - #2265
Merged
Merged
Conversation
yuandrew
force-pushed
the
missing-heartbeat-identity
branch
from
July 13, 2026 16:12
3bc88b0 to
1397228
Compare
yuandrew
marked this pull request as ready for review
July 13, 2026 16:14
dplyukhin
approved these changes
Jul 14, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit fd335be. Configure here.
yuandrew
enabled auto-merge (squash)
July 28, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What was changed
interval.
elapsed_since_last_heartbeatunset on the first heartbeat.RecordWorkerHeartbeatRequest.identityis sent.Why?
Match behavior with Java and Rust
Checklist
Closes
How was this tested:
Note
Low Risk
Observability and RPC field population only; no task execution or auth changes, with new unit tests covering the behavior.
Overview
Aligns Go worker heartbeat behavior with the Java and Rust SDKs.
The shared namespace heartbeat loop now fires one
RecordWorkerHeartbeatas soon as it starts, instead of waiting a full interval. Worker callbacks are registered before that goroutine starts so the first batch includes the new worker.RecordWorkerHeartbeatRequestnow setsIdentityfrom the Temporal client (ClientOptions.Identity). EachWorkerHeartbeatleaveselapsed_since_last_heartbeatunset on the first report and only populates it after a prior heartbeat timestamp exists.Reviewed by Cursor Bugbot for commit 9352831. Bugbot is set up for automated code reviews on this repo. Configure here.