feat(otel): add UseMonotonicCounters option for correct Prometheus counter type#2340
Open
apridosimarmata wants to merge 1 commit into
Open
Conversation
|
|
|
Imam Aprido Simarmata seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…unter type Adds a UseMonotonicCounters option to MetricsHandlerOptions that switches Counter() from Int64UpDownCounter to Int64Counter when enabled. This causes Prometheus to correctly report counters with the _total suffix instead of treating them as gauges. The default remains Int64UpDownCounter for backward compatibility. Fixes temporalio#2140
1e60570 to
0354ed1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenTelemetry metrics handler uses
Int64UpDownCounterfor all counters. This causes Prometheus to report Temporal counters (likeworkflow_completed) as gauges instead of counters with the_totalsuffix, sinceInt64UpDownCounteris non-monotonic.See #2140 for details.
Solution
Added a
UseMonotonicCountersoption toMetricsHandlerOptions. When set totrue, the handler creates counters usingInt64Counter(monotonic) instead ofInt64UpDownCounter.The default remains
falsefor backward compatibility, as discussed in the issue thread.Usage
Testing
Added
TestMonotonicCounterHandlerthat verifies counters are reported withIsMonotonic: truewhen the option is enabled. All existing tests continue to pass.Fixes #2140