feat: Deserialize Priority in schedule Describe#2365
Open
brucearctor wants to merge 2 commits into
Open
Conversation
Fixes temporalio#2350 The Priority field was already serialized when creating/updating a schedule (convertToPBScheduleAction), but the deserialization path in convertFromPBScheduleAction was missing. This meant that ScheduleHandle.Describe() would always return a zero-value Priority, breaking the Describe→Modify→Update round-trip. Changes: - Add convertFromPBPriority call in convertFromPBScheduleAction - Add WARNING experimental tag to ScheduleWorkflowAction.Priority (consistent with StartChildWorkflowOptions.Priority in workflow.go) - Add TestConvertPriority/TestConvertPriorityNil converter round-trips - Add TestCreateAndDescribeScheduleWithPriority for Create+Describe - Add TestUpdateSchedulePreservesPriority for Update lifecycle - Extract newDescribeResponseWithPriority test helper to reduce protobuf mock duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #2350
The
Priorityfield was already serialized when creating/updating a schedule (convertToPBScheduleAction), but the deserialization path inconvertFromPBScheduleActionwas missing. This meant thatScheduleHandle.Describe()would always return a zero-valuePriority, breaking the Describe→Modify→Update round-trip.Changes
convertFromPBPrioritycall inconvertFromPBScheduleAction(1 line)WARNING: experimentaltag toScheduleWorkflowAction.Prioritydoc (consistent withStartChildWorkflowOptions.Priorityinworkflow.go)TestConvertPriority/TestConvertPriorityNil— converter round-trip tests (mirrorsTestConvertRetryPolicy)TestCreateAndDescribeScheduleWithPriority— Create + Describe pathTestUpdateSchedulePreservesPriority— full Update lifecycle (Describe→Modify→Serialize)newDescribeResponseWithPrioritytest helperTesting
All 15 suite tests pass, including 5 new ones.