Clear worker slot metrics on stop#2412
Open
kritibehl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR clears worker slot gauges when a worker stops.
Specifically, it adds metric cleanup to the tracking slot supplier and calls it from
baseWorker.Stop()after worker shutdown/drain. The cleanup is idempotent and guarded so late slot releases after shutdown do not republish stale slot availability.A regression test was added to verify that worker slot gauges are reset to zero on stop and remain zero after a late slot release.
Why?
Stopped workers should not continue reporting available task capacity through
worker_task_slots_available.Without cleanup, slot metrics can remain at their last published value after worker shutdown, which may leave stale capacity signals in metrics reporting.
Checklist
Closes Ensure slots available metric is updated on worker stop #873
How was this tested:
go test ./internal -run 'TestScalableTaskPollerSuite/TestTrackingSlotSupplierStopsSlotMetrics' -count=1go test ./internal -run 'TestScalableTaskPollerSuite/TestTrackingSlotSupplier' -count=1go test ./internal -race -run 'TestScalableTaskPollerSuite/TestTrackingSlotSupplierStopsSlotMetrics' -count=1go test ./internal -count=1No docs updates needed.