NEXUS-550: Nexus Operation Query support - #2508
Draft
mavemuri wants to merge 2 commits into
Draft
Conversation
| // These are free functions because Go does not allow generic methods on non-generic structs. | ||
| // | ||
| // NOTE: Experimental | ||
| func StartQueryWorkflow[R any]( |
Contributor
There was a problem hiding this comment.
We agreeded we would just use the regular clients query method, we don't need to add these
| // QueryRejectCondition is the query reject condition. | ||
| QueryRejectCondition enumspb.QueryRejectCondition | ||
| // gRPC request response trap for nexus forward links | ||
| responseInfo *queryWorkflowResponseInfo |
Contributor
There was a problem hiding this comment.
This is overkill for queries , in the query handler we can just do something like what we did for signal eg:
// If this signal was issued from inside a Nexus operation handler, capture the server's response
// link (pointing at the WorkflowExecutionSignaled event) so the task handler can attach it to the
// StartOperationResponse, linking the caller workflow's history event to the callee. Servers
// without history.enableCHASMSignalBacklinks leave the link unset; AddResponseLink ignores
// nil.
if nctx, ok := NexusOperationContextFromGoContext(ctx); ok {
nctx.AddResponseLink(response.GetLink())
}
| // NOTE: Experimental | ||
| func ConvertWorkflowLinkToNexusLink(workflowLink *commonpb.Link_Workflow) nexus.Link { | ||
| return apinexus.ConvertWorkflowLinkToNexusLink(workflowLink) | ||
| // TODO: when bumping up api-go, also fix "ConvertWorkflowLinkToNexusLink" to use urlPathWorkflowTemplate |
Contributor
There was a problem hiding this comment.
If there is a bug here we should fix it before updating the api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds support for QueryWorkflow as a Nexus operation
Why?
Part of effort to expose all Temporal primitives via Nexus operations
Checklist
Closes NEXUS-550
How was this tested: