Bump auto-enroll autoscaling minimum to the fixed poller default - #2509
Draft
veeral-patel wants to merge 1 commit into
Draft
Bump auto-enroll autoscaling minimum to the fixed poller default#2509veeral-patel wants to merge 1 commit into
veeral-patel wants to merge 1 commit into
Conversation
When auto-enrolling into poller autoscaling via the PollerAutoscalingAutoEnroll namespace capability, initialize the behavior with explicit min/max/initial (2/100/5) instead of relying on the library defaults.
veeral-patel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a worker auto-enrolls into poller autoscaling (via the
PollerAutoscalingAutoEnrollnamespace capability), it previously started with a minimum of 1 poller. That's fewer than the fixed default (2) a worker would otherwise run, so auto-enrolling could cause a throughput regression from too few pollers.This sets the autoscaling minimum equal to the fixed default poller count, so auto-enrolling never starts below what a non-autoscaling worker would use.
What
Auto-enroll now uses explicit values:
Applies to workflow, activity, and nexus pollers.
Tested:
go test ./internal/ -run TestInternalWorkerTestSuite/TestPollerAutoscalingAutoEnrollpasses.