Print only test failures by default, full logs in files - #2510
Draft
yuandrew wants to merge 2 commits into
Draft
Conversation
yuandrew
force-pushed
the
try-out-ci-shenanigans
branch
from
July 29, 2026 21:50
1df4454 to
ec7437d
Compare
yuandrew
commented
Jul 29, 2026
| // We cannot check PollActivityTaskQueue metric because eager activities | ||
| // affect poll count | ||
| ts.assertMetricCountAtLeast("temporal_long_request", 3, "operation", "PollWorkflowTaskQueue") | ||
| ts.Fail("intentional failure to demonstrate CI test output") |
Contributor
Author
There was a problem hiding this comment.
NOTE: Will remove before merging, but keeping here until we're ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Only print tests run and test failure logs.
Unit test output goes from ~7600 to ~40 lines
Integ test output goes from ~6000 to
Why?
Inspired by temporalio/sdk-typescript#2270, we never care about all of the lot spew for passing tests, only for the failures. So let's make only-failure output by default, while maintaining access to full logs with files if someone actually cares
Checklist
Closes
How was this tested: