Skip to content

Add includeHeartbeatDetails and includeLastFailure to DescribeActivityExecution requests#3521

Open
laurakwhit wants to merge 1 commit into
mainfrom
feat/add-fields-for-DescribeActivityExecution
Open

Add includeHeartbeatDetails and includeLastFailure to DescribeActivityExecution requests#3521
laurakwhit wants to merge 1 commit into
mainfrom
feat/add-fields-for-DescribeActivityExecution

Conversation

@laurakwhit

@laurakwhit laurakwhit commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Defaults includeHeartbeatDetails and includeLastFailure to true in getActivityExecution and pollActivityExecution requests.

Related to temporalio/api#792.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-4157

Docs

Any docs updates needed?

…tActivityExecution and pollActivityExecution
@laurakwhit laurakwhit requested a review from a team as a code owner June 10, 2026 01:18
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jun 10, 2026 1:18am

Request Review

@temporal-cicd

temporal-cicd Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 2 errors in 1 file (0.2% of 902 total)

src/lib/services/standalone-activities.ts (2)
  • L127:6: Type '{ indexedFields?: ({ [k: string]: temporal.api.common.v1.IPayload; } | null); }' is not assignable to type '{ [k: string]: IPayload; }'.
  • L133:2: Type '{ retryPolicy: { backoffCoefficient?: number | undefined; maximumAttempts?: number | undefined; maximumInterval?: string | undefined; initialInterval?: string | undefined; }; scheduleToStartTimeout?: string | undefined; ... 10 more ...; userMetadata: { ...; }; }' is not assignable to type 'StartActivityExecutionRequest'.

Generated by 🚫 dangerJS against 9254bbc

@laurakwhit laurakwhit marked this pull request as draft June 10, 2026 18:15
@laurakwhit laurakwhit marked this pull request as ready for review June 26, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants