test(e2e): show CI timings and keep services on fork timeout#173
Draft
aprimakina wants to merge 1 commit into
Draft
test(e2e): show CI timings and keep services on fork timeout#173aprimakina wants to merge 1 commit into
aprimakina wants to merge 1 commit into
Conversation
Add `-v` to the CI `go test` command so per-test and per-subtest durations are always visible in CI logs, making it easy to see how long each E2E test ran and spot slow/hanging operations. In TestServiceForkIntegration, when a fork command fails specifically because its wait-timeout was exceeded, keep the source and forked services instead of deleting them so the failure can be investigated. Remaining subtests are skipped and the deferred cleanups log the kept service IDs; the existing 1h stale-service sweeper reclaims them later. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two improvements to the E2E fork integration test and CI, aimed at diagnosing intermittent fork-provisioning slowness:
-vto the CIgo testcommand (.github/workflows/test.yml) so per-test and per-subtest durations are printed (--- PASS: TestServiceForkIntegration/ForkService_Now (35.2s)). Makes it easy to see how long each E2E test ran and spot a slow/hanging operation.TestServiceForkIntegration, when a fork command fails specifically because its--wait-timeoutwas exceeded (CLI exit code 2), the source service and the forked service are no longer deleted, so the failure can be investigated. Remaining subtests are skipped, and the deferred cleanups log the kept service IDs. The existing 1hsweepStaleIntegrationServicesreclaims them on a later run, so nothing leaks permanently.Non-timeout failures and the normal success path are unchanged — services are still cleaned up as before.
Implementation notes
handleForkErrcentralizes the three forks' error handling; on a wait-timeout it captures the fork's service ID (the fork command prints the service JSON even on timeout), flags the run, and reports both IDs.errors.Asagainstcommon.ExitCodeError/common.ExitTimeout.cleanupServicehelper.