Pass --regex-pattern through to slugify() from the CLI#184
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
slugify_params() built the kwargs for slugify() but omitted regex_pattern, so the CLI silently ignored --regex-pattern. Wire it through and add a CLI test. Fixes un33k#175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175.
slugify_params()inslugify/__main__.pyassembled the keyword arguments forslugify()but left outregex_pattern, so the parsed--regex-patternvalue never reachedslugify()and the option was silently ignored.Before
After
Added
regex_patternto the CLIDEFAULTSand atest_regex_patterncase that checks both the parsed params and that the pattern actually reachesslugify(). Full suite:83 passed.