Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools==80.9.0", "setuptools-scm==9.2.0"]
requires = ["setuptools==82.0.1", "setuptools-scm==9.2.2"]
build-backend = "setuptools.build_meta"

[project]
Expand Down Expand Up @@ -38,7 +38,7 @@ dependencies = [
# --- Shared deps (all platforms) ---
"packaging>=24.1",
"transformers>=4.51.3,!=4.52.0,!=4.52.1,!=4.52.2,!=4.52.3,!=4.53.0,!=4.54.0,!=4.55.0,!=4.55.1,!=4.57.4,!=4.57.5,!=5.0.0,!=5.1.0,<=5.5.0",
"datasets>=3.4.1,!=4.0.*,!=4.1.0,<4.4.0",
"datasets>=4.0,<4.6",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude the broken datasets releases

This range now permits datasets==4.5.0, which is the version this dependency bump is intended to select, but the repo explicitly treats 4.4.0 through 4.5.0 as broken: patch_datasets() raises for that window in unsloth_zoo/import_fixes.py:727, and tests/test_upstream_import_fixes_drift.py:141 asserts installed datasets must not fall in it because of recursion errors. A fresh install will therefore choose a version the project already marks unusable; keep <4.4.0 or exclude >=4.4.0,<=4.5.0 until a safe release is available.

Useful? React with 👍 / 👎.

"sentencepiece>=0.2.0",
"tqdm",
"psutil",
Expand Down Expand Up @@ -76,7 +76,7 @@ core = [
"packaging>=24.1",
"tyro",
"transformers>=4.51.3,!=4.52.0,!=4.52.1,!=4.52.2,!=4.52.3,!=4.53.0,!=4.54.0,!=4.55.0,!=4.55.1,!=4.57.4,!=4.57.5,!=5.0.0,!=5.1.0,<=5.5.0",
"datasets>=3.4.1,!=4.0.*,!=4.1.0,<4.4.0",
"datasets>=4.0,<4.6",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the core extra off broken datasets releases

Even if the top-level requirement is fixed, this duplicate core extra constraint still permits datasets==4.5.0, and base, huggingface, and intelgpu all include unsloth_zoo[core]. The repo's drift test at tests/test_upstream_import_fixes_drift.py:86-98 explicitly rejects datasets 4.4.0 through 4.5.0 because that range triggers _thread.RLock_recursion_count errors, so installing any of those extras can still resolve to a version the project marks unusable.

Useful? React with 👍 / 👎.

"sentencepiece>=0.2.0",
"tqdm",
"psutil",
Expand Down
Loading