test: add report writer artifact tests#667
Open
Ayush7614 wants to merge 1 commit into
Open
Conversation
Cover run record I/O, vulnerability markdown rendering, CSV severity ordering, and executive report output.
Contributor
Greptile SummaryThis PR adds unit tests for the report writer helpers. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "test: add report writer artifact tests" | Re-trigger Greptile |
Contributor
Author
|
cc: @rajpratham1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for pure helpers in
strix.report.writer— previously uncovered aside from SARIF tests.Covers:
read_run_record()— missing file, corrupt JSON, non-object payloadwrite_run_record()round-triprender_vulnerability_md()section outputwrite_vulnerabilities()— markdown/CSV/JSON artifacts, severity ordering, skip-already-saved IDswrite_executive_report()outputWhy
_parse_dedupe_response/ usage helpers) ortests/test_sarif.pyVerification
Test plan
pytest tests/test_report_writer.py— 8 passed locallyruff check tests/test_report_writer.py— clean