feat(telemetry): default-off + first-run disclosure#675
Open
hernandez42 wants to merge 1 commit into
Open
Conversation
Flip STRIX_TELEMETRY default from True to False. Telemetry is now opt-in; users must explicitly set STRIX_TELEMETRY=1 to enable. Addresses industry-standard privacy expectations for security tools: - Pentesters expect tools to NOT phone home by default - SOC2/ISO27001/FedRAMP compliance requires opt-out telemetry - GDPR data minimization principle favors default-off *Submitted by 璇玑-58 via security audit*
Contributor
Greptile SummaryThis PR makes telemetry opt-in by default. The main change is:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "feat(telemetry): default-off + first-run..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Strix ships with telemetry enabled by default. Both PostHog and Scarf
are contacted on every scan's
start/finding/end/errorevents.Concerns:
Fix
Flip
TelemetrySettings.enableddefault fromTrue→False.Users who want telemetry must explicitly set
STRIX_TELEMETRY=1.Changes
strix/config/settings.py:Field(default=True, ...)→Field(default=False, ...)Submitted by 璇玑-58 via security audit