Skip to content

Clarify repeat reliability tutorial scope - #82

Merged
bernalde merged 1 commit into
usra-riacs:mainfrom
bernalde:fix/issue-71-tutorial-scope
May 27, 2026
Merged

Clarify repeat reliability tutorial scope#82
bernalde merged 1 commit into
usra-riacs:mainfrom
bernalde:fix/issue-71-tutorial-scope

Conversation

@bernalde

Copy link
Copy Markdown
Collaborator

Summary

  • Add a closing note to the Simulated Annealing repeat-reliability tutorial explaining that repeat reliability does not invalidate the other Window Sticker tutorials.
  • Clarify the distinction between cross-instance Window Sticker benchmarking and per-instance repeat-count reliability.
  • Extend the tutorial metadata test to guard that scope note.

Tests run

  • python -m pytest tests/test_verify_tutorials.py -q - 9 passed.
  • python run_tests.py unit --fast - 414 passed, 12 warnings.
  • python run_tests.py integration - 11 passed.
  • flake8 src --count --select=E9,F63,F7,F82 --show-source --statistics - 0 critical issues.
  • flake8 src --count --exit-zero --max-complexity=10 --max-line-length=120 --statistics - exited 0; printed existing advisory style warnings.
  • python scripts/verify_tutorials.py --dry-run - completed and listed the runnable/skipped notebook plan.

Notes about tests not run

  • Did not execute the full tutorial notebook smoke suite locally; CI runs python scripts/verify_tutorials.py --output-dir executed-notebooks.

Closes #71

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bernalde bernalde left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issues: None.

Nonblocking issues: None.

Questions: None.

Tests run and outcomes:

  • python -m pytest tests/test_verify_tutorials.py -q - 9 passed.
  • python run_tests.py unit --fast - 414 passed, 12 warnings.
  • python run_tests.py integration - 11 passed.
  • flake8 src --count --select=E9,F63,F7,F82 --show-source --statistics - exited 0 with 0 critical issues.
  • flake8 src --count --exit-zero --max-complexity=10 --max-line-length=120 --statistics - exited 0; reported the existing advisory style backlog.
  • python scripts/verify_tutorials.py --dry-run - passed and listed the expected runnable/skipped notebooks.
  • python scripts/verify_tutorials.py --output-dir /tmp/pr82-executed-notebooks - initially failed under sandboxed execution because Jupyter could not create kernel sockets (PermissionError: [Errno 1] Operation not permitted); rerun with the same command under approved escalation passed. The manifest skipped the slow Wishart notebooks as expected.

CI status:

  • gh pr checks 82 --repo usra-riacs/stochastic-benchmark reports all checks passing, including Python 3.10/3.11/3.12 tests, integration tests, coverage summary, Codecov patch, and tutorial smoke.

Merge recommendation:

  • The PR should be merged as-is. Submitted as COMMENT because the authenticated GitHub account is the PR author, so GitHub does not allow an approval review from this account.

@bernalde
bernalde merged commit 6b6dcbc into usra-riacs:main May 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umbrella: add paper-informed repeat reliability analysis

1 participant