Skip to content

[docker] feat: upgrade vllm, TE and megatron version#7101

Open
ETOgaosion wants to merge 21 commits into
verl-project:mainfrom
ETOgaosion:docker/upgrade_vllm_megatron
Open

[docker] feat: upgrade vllm, TE and megatron version#7101
ETOgaosion wants to merge 21 commits into
verl-project:mainfrom
ETOgaosion:docker/upgrade_vllm_megatron

Conversation

@ETOgaosion

Copy link
Copy Markdown
Collaborator

What does this PR do?

upgrade vllm (0.24.0) and megatron (core_v0.18.0) version

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfiles for SGLang and vLLM to parameterize the megatron-bridge version and simplifies the vLLM installation by using pip instead of building from source. The feedback highlights that the vllm-omni package version is hardcoded to 0.24.0 in the vLLM Dockerfile instead of utilizing the newly introduced VLLM_OMNI_VERSION build argument.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/Dockerfile.stable.vllm Outdated
@ETOgaosion ETOgaosion changed the title [docker] misc: upgrade vllm and megatron version [docker] feat: upgrade vllm and megatron version Jul 21, 2026

@wuxibin89 wuxibin89 Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HollowMan6 Can we remove all on-fly megatron-bridge and megatron installation now?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if we have the expected megatron-bridge and megatron-lm installed in the container image.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove all on-fly megatron-bridge and megatron installation and run the CI to see if there's any issue.

@ETOgaosion ETOgaosion Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Megatron Bridge/TransferQueue will be built in with this image.

@ETOgaosion
ETOgaosion force-pushed the docker/upgrade_vllm_megatron branch from b34018e to 9a5d832 Compare July 21, 2026 07:59
@ETOgaosion

Copy link
Copy Markdown
Collaborator Author

transformers is troublesome, we will not force single version transformers work with verl, we shall built in with image, and accelerate uv integration to handle conflicts.

@ETOgaosion
ETOgaosion requested a review from tongyx361 as a code owner July 22, 2026 12:40
@ETOgaosion ETOgaosion changed the title [docker] feat: upgrade vllm and megatron version [docker] feat: upgrade vllm, TE and megatron version Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants