[docker] feat: upgrade vllm, TE and megatron version#7101
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfiles for SGLang and vLLM to parameterize the megatron-bridge version and simplifies the vLLM installation by using pip instead of building from source. The feedback highlights that the vllm-omni package version is hardcoded to 0.24.0 in the vLLM Dockerfile instead of utilizing the newly introduced VLLM_OMNI_VERSION build argument.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
@HollowMan6 Can we remove all on-fly megatron-bridge and megatron installation now?
There was a problem hiding this comment.
Yes if we have the expected megatron-bridge and megatron-lm installed in the container image.
There was a problem hiding this comment.
I think we can remove all on-fly megatron-bridge and megatron installation and run the CI to see if there's any issue.
There was a problem hiding this comment.
Megatron Bridge/TransferQueue will be built in with this image.
b34018e to
9a5d832
Compare
|
|
What does this PR do?
upgrade vllm (0.24.0) and megatron (core_v0.18.0) version
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.