Skip to content

Fix SeqManager::GetMaxOutput() #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibc merged 2 commits into from
Jun 18, 2026
+173 −63
Merged

Fix SeqManager::GetMaxOutput() #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe30094
Fix `SeqManager::GetMaxOutput()`
ibc Jun 18, 2026
8b3b5d7
CHANGELOG
ibc Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### NEXT

- Worker: Replace `uint64_t` hash with `TupleKey` in `TransportTuple` to avoid hash collisions ([1823](https://github.com/versatica/mediasoup/pull/1823)).
- Worker: Fix `SeqManager::GetMaxOutput()` ([1840](https://github.com/versatica/mediasoup/pull/1840)).

### 3.20.8

Expand Down
1 change: 1 addition & 0 deletions rust/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### NEXT

- Worker: Replace `uint64_t` hash with `TupleKey` in `TransportTuple` to avoid hash collisions ([1823](https://github.com/versatica/mediasoup/pull/1823)).
- Worker: Fix `SeqManager::GetMaxOutput()` ([1840](https://github.com/versatica/mediasoup/pull/1840)).

### 0.22.8

Expand Down
5 changes: 4 additions & 1 deletion worker/src/RTC/SeqManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ namespace RTC
template<typename T, uint8_t N>
T SeqManager<T, N>::GetMaxOutput() const
{
return this->maxOutput;
// 'maxOutput' is stored in the offset-less space (as 'base' and comparisons
// use it), so apply 'initialOutput' here, just like `Input()` does before
// returning the output to the caller.
return (this->maxOutput + this->initialOutput) & SeqManager::MaxValue;
}

/*
Expand Down
Loading
Loading