Skip to content

Jaghov/instant animations#109

Draft
Jaghov wants to merge 2 commits into
mainfrom
jaghov/instant-animations
Draft

Jaghov/instant animations#109
Jaghov wants to merge 2 commits into
mainfrom
jaghov/instant-animations

Conversation

@Jaghov

@Jaghov Jaghov commented May 29, 2026

Copy link
Copy Markdown
Contributor

Purpose:

Addresses #108

Original Issue

instant animations of the form:

let instant_frag = b.act(id, path!(..), move |_| x).play(0.0);

Had an issue of creating sequences where the start and the end had the exact same time.

Solution

Ensure the start and end values aren't the same by adding a small delta to the duration before constructing an ActionClip with a minimum duration of delta = f32::MIN_POSITIVE.

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 361d64a7-5ab8-4c91-84ae-9ddcb50a098a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant