ASM2d-N2O Model Development - #1605
Open
MarcusHolly wants to merge 37 commits into
Open
Conversation
MarcusHolly
marked this pull request as ready for review
July 23, 2025 10:59
MarcusHolly
requested review from
Morgan88888888,
adam-a-a and
agarciadiego
as code owners
July 23, 2025 10:59
adam-a-a
reviewed
Jul 31, 2025
Comment on lines
+569
to
+570
| # TODO: Double check these effluent metrics | ||
|
|
Contributor
There was a problem hiding this comment.
Marking this todo- should address or be sure to track in an issue if we decide to handle later.
Contributor
Author
There was a problem hiding this comment.
These should be handled later as they were not mentioned in the c files. I can make educated guesses as to what they might be based on my understanding of the changes I made, but we should find a literature reference to confirm this.
adam-a-a
reviewed
Jul 31, 2025
adam-a-a
reviewed
Jul 31, 2025
MarcusHolly
requested review from
adam-a-a
and removed request for
Morgan88888888
April 28, 2026 13:42
Contributor
Author
|
This PR doesn't have any of the errors identified in the previous BSM2 implementations, but we should keep those modifications in mind when developing the ADM model that is compatible with ASM2d-N2O. The only thing potentially withholding this PR from being merged would be if we want to add conservation tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Develops the activated sludge process model no.2d, which accounts for phosphorus (P), sulfur (S), iron (Fe), and greenhouse gas emission (N2O), but this preliminary model only accounts for P and GHG, so it'll be referred to as the ASM2d-N2O model.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: