Add Multi-Stage RO Flowsheet and UI - #1759
Conversation
…to multi-stage-ro-fs
…to multi-stage-ro-fs
…to multi-stage-ro-fs
|
|
||
| stage.RO.length.setlb(1 * pyunits.meter) | ||
| stage.RO.width.setlb(0.1 * pyunits.meter) | ||
| stage.RO.feed_side.velocity[0, 0].setub(0.3) |
There was a problem hiding this comment.
This seems like a pretty restrictive upper bound on inlet crossflow velocity. How necessary is this?
| stage.RO.length.setlb(1 * pyunits.meter) | ||
| stage.RO.width.setlb(0.1 * pyunits.meter) | ||
| stage.RO.feed_side.velocity[0, 0].setub(0.3) | ||
| stage.RO.feed_side.velocity[0, 0].setlb(0.1) |
There was a problem hiding this comment.
Same question here- is this lower bound really necessary?
There was a problem hiding this comment.
this may have just been necessary for the analysis implementation, but there also may be a practical/design reason that @avdudchenko can maybe comment on
|
@kurbansitterley before I go further, any reason why this is still in draft mode? |
I need to create a figure/pfd for it |
…to multi-stage-ro-fs
…eate unfix_system_design func
MarcusHolly
left a comment
There was a problem hiding this comment.
LGTM - just a few comments to address as well as the failing test. I've tested the GUI and everything seems to be working fine
| # salinity = [35] | ||
| # flows = [1] | ||
| # recovery = [0.5] | ||
| # n_stages = [2] | ||
| # add_erd = [True] |
| # stage.RO.feed_side.velocity[0, 0].setub(0.3) | ||
| # stage.RO.feed_side.velocity[0, 0].setlb(0.1) |
There was a problem hiding this comment.
Should this be deleted?
Fixes/Resolves:
Adds multi-stage RO flowsheet and UI file.
Summary/Motivation:
This flowsheet was created for a separate analysis effort and would be useful to have in main WaterTAP since there isn't something similar, and multi-stage RO might be a common system for users to need to model.
The code is written such that a user can create a flowsheet with any number of stages for any inlet condition (flow and concentration). From the build function, the user can specify:
The test file represents the spectrum of conditions that I have tested that the default settings for flowsheet is stable for.
Extensions of these ranges may be stable but haven't been tested. More fine-grained tests could be added but would extend testing time. Currently runs ~5 min locally for testing time.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: