Skip to content

Migrate bipolar electrodialysis model - #1778

Draft
luohezhiming wants to merge 7 commits into
watertap-org:mainfrom
luohezhiming:migrate_bipolar
Draft

Migrate bipolar electrodialysis model#1778
luohezhiming wants to merge 7 commits into
watertap-org:mainfrom
luohezhiming:migrate_bipolar

Conversation

@luohezhiming

Copy link
Copy Markdown
Contributor

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@luohezhiming
luohezhiming requested a review from tristantc May 14, 2026 20:27
@luohezhiming luohezhiming self-assigned this May 14, 2026
@sufikaur sufikaur added the Priority:Normal Normal Priority Issue or PR label May 21, 2026
@sufikaur
sufikaur requested a review from avdudchenko May 21, 2026 20:23
@sufikaur

sufikaur commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@johnson12742
FYI errors were identified on the BMED model

@johnson12742

Copy link
Copy Markdown
Contributor

@sufikaur Thank you for flagging this. I don't have a project to charge to and so I haven't join the dev calls (and didn't see the pull request). Is there a place where the issues were documented? If you can share it with me I will try to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants