Document SteamHeater0D unit model - #1837
Conversation
899c570 to
f1332d7
Compare
MarcusHolly
left a comment
There was a problem hiding this comment.
Thanks for putting this together, just a few improvements to be made. I'd be fine with merging this as is and refining at a later date if we just want to get some level of documentation in before the release.
|
The PR description is missing the required Legal Acknowledgment section to contribute code. |
|
We would need to ensure the documentation aligns with the latest revisions to the steamheater model, which may have removed the heater and condenser modes. We'll need to double-check to be sure. |
|
Thanks @adam-a-a. I double-checked against the current
So nothing was removed. The reference page documents exactly those two config options, the two added hot-side constraints ( |
#1760 would go in first so this doc should align with the model there. |
659a13c to
6c064a9
Compare
|
@kurbansitterley #1760 has merged, so I rebased this doc onto latest main and confirmed it matches the updated SteamHeater0D model:
Every model object referenced in the page exists in the merged model. Ready for another look. |
|
will work on this tdy. |
6c064a9 to
8b21449
Compare
|
Thanks @MarcusHolly. I have addressed all three points:
The branch is rebased onto latest main (post #1760) and I verified the page against the current steam_heater_0D.py. The Read the Docs build passes. Please let me know if you would like anything else refined. |
Fixes #1825.
Summary
SteamHeater0D.Validation
python -c "from watertap.unit_models.steam_heater_0D import SteamHeater0D, Mode"git diff --checksphinx-build -M html docs docs/_build -W --keep-goingcompleted HTML generation and did not emit warnings for the newsteam_heater_0D.rstpage. The local command exited nonzero because existing/global docs warnings were treated as errors, including unreachable intersphinx inventories and existing unresolved references outside this change.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: