Fix TS errors and replace getAdapterLogger in modules/astro-app#14275
Merged
Conversation
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Preview deployment ✅ Deployment complete!
|
ArmandPhilippot
marked this pull request as ready for review
July 17, 2026 16:39
modules/astro-app code snippetsgetAdapterLogger in modules/astro-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Follow-up of #14089. TL;DR: Improve UX by preventing the appearance of red squiggles (TS) and visual changes (formatting with Astro extension) when the user copies and pastes a code snippet.
Formats and fixes code snippets in
modules/astro-app.mdx:createApp(): useless import and we have the following errorProperty 'respondWith' does not exist on type 'Event'.ts(2339)... The fix I'm suggesting is only available when settingwebworkerincompilerOptions.libbut I guess this is expected: on MDN, they say that "This feature is only available in Service Workers."app.render()... those can be confusing for users (e.g. where doesrequestcomes from). I tried to integrate them into a complete example (not an adapter expert though...). And I converted them as TypeScript examples: I believe it's easier to remove the types rather than wasting time to find them.app.getAdapterLogger(): doesn't exist. It was removed in6.3.0with experimental advanced routing. But, we haveapp.adapterLogger(a getter) since 6.2.0. So, I updated the heading, the signature,<Since />, and the code snippet.References