Skip to content

vim: Remap cursor position with display_point#60755

Open
HuaGu-Dragon wants to merge 2 commits into
zed-industries:mainfrom
HuaGu-Dragon:fix-duplicate
Open

vim: Remap cursor position with display_point#60755
HuaGu-Dragon wants to merge 2 commits into
zed-industries:mainfrom
HuaGu-Dragon:fix-duplicate

Conversation

@HuaGu-Dragon

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Replace the direct DisplayPoint::new(row, col) construction with a proper buffer-point-to-display-point
  • This goes through the full inlay → fold → tab → wrap → block pipeline and correctly accounts for any inlay hints on the target line.

Testing

  • Added a regression test for multi-cursors with inlay hints in helix mode

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed Shift+C cursor position with inlay hints in helix mode

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jul 10, 2026
@maxdeviant maxdeviant changed the title fix: remap cursor position with display_point vim: Remap cursor position with display_point Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helix: duplicate cursor below seems broken on go files Helix mode multi-cursors broken by inlay hints

1 participant