Improve JS/TS/TSX parameter highlighting for destructuring#60767
Merged
ChristopherBiscardi merged 1 commit intoJul 12, 2026
Merged
Conversation
61ab294 to
d9b02a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #51967
Destructured JS/TS/TSX parameters with defaults were not highlighted consistently as parameters when using themes that distinguish arguments from variables/properties, such as Catppuccin.
For example, in:
argumentwas parsed under a default assignment pattern and did not receive the same@variable.parametercapture as a destructured parameter without a default.This also affected array binding patterns with defaults, such as:
Solution
Updated the JS/TS/TSX highlight queries to capture destructured parameters with default values as
@variable.parameter.This covers both:
{ argument = true }[argument = true]As a result, destructured parameters are highlighted consistently whether or not they provide a default value.
Testing
Self-Review Checklist:
Showcase
Before this change,

After this change:

Release Notes: