[STACKED PR] csv_preview: Evolve into tabular data preview#60768
Draft
HalavicH wants to merge 19 commits into
Draft
[STACKED PR] csv_preview: Evolve into tabular data preview#60768HalavicH wants to merge 19 commits into
HalavicH wants to merge 19 commits into
Conversation
Reuse storage icon for pipe-separated and semicolon-separated value files. Maintains visual consistency with CSV and TSV format icons.
- Create table.svg icon (3x3 grid design, 16x16 viewBox) - Add Table variant to IconName enum - Use Table icon for CSV preview tabs instead of FileDoc
cla-bot
Bot
added
the
cla-signed
HalavicH
force-pushed
the
local/feat/csv-preview/evolve-into-tabular-data-preview
branch
from
9aa85d9 to
eabd513
Compare
HalavicH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The MVP version of CSV preview is ready. However it's trivial to extend it to TSV & other formats.
Solution
This PR does exactly that - switching from CSV only to any tabular data (TSV/CSV/PSV/SSV).
tsv/psv/ssvsupport.psv/.ssvtypes to use database icon (similar tocsv/tsv)Tablesvg icon (was previously missing) so preview is not longer using book icon (from markdown preview).Testing
Opened csv/tsv/psv/ssv files in peview
Self-Review Checklist:
Showcase
PSV/SSV file formats icon
Change namespace for actions (
csv->tabular data)Update parser & detection logic to support preview for TSV/PSV/SSV
Introduce table svg icon
Release Notes: