Skip to content

settings_ui: Shrink constraint on minimum window width#60786

Open
feitreim wants to merge 1 commit into
zed-industries:mainfrom
feitreim:bugfix-settings-width
Open

settings_ui: Shrink constraint on minimum window width#60786
feitreim wants to merge 1 commit into
zed-industries:mainfrom
feitreim:bugfix-settings-width

Conversation

@feitreim

Copy link
Copy Markdown
Collaborator

Objective

Right now the minimum width of the settings window is 900px, this makes it so that when I open it with my window manager (aerospace), it goes off the screen on the right side.

before-small.mov

Solution

There is a comment, that says:

// Don't make the settings window thinner than this,
// otherwise, it gets unusable. Users with smaller res monitors
// can customize the height, but not the width.
width: px(900.0),
height: px(240.0),

the comment and limit was added in #44505, which added the edit prediction provider ui. Now in the past, in #51878 I fixed a bug with the way that the edit prediction provider and some of the other sub menu type pages in the settings menu displayed. There isn't really any record of what specifically made the window unusable below 900px besides the issue that I fixed in #51878.

Testing

I tested it by just sort of poking around the different settings pages, especially the ones I fixed in #51878, and every thing seems totally fine to me. That said I haven't exhaustively checked every page and if there was any more information on what that comment was referring to that would be awesome.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Showcase

How it looks after the change:

after-small.mov

Release Notes:

  • settings_ui: Allowed window widths below 900px

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jul 11, 2026
@zed-community-bot zed-community-bot Bot added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Jul 11, 2026
@maxdeviant maxdeviant changed the title settings_ui: shrink/ constraint on minimum window width settings_ui: Shrink constraint on minimum window width Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant