Skip to content

chore(vscode): Move information messages to logs, prevent automatically opening outputs view#9370

Open
andrew-eldridge wants to merge 4 commits into
mainfrom
aeldridge/outputLogsUpdate
Open

chore(vscode): Move information messages to logs, prevent automatically opening outputs view#9370
andrew-eldridge wants to merge 4 commits into
mainfrom
aeldridge/outputLogsUpdate

Conversation

@andrew-eldridge

@andrew-eldridge andrew-eldridge commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

  • Move several information messages to output channel logs to reduce clutter
  • Similarly, avoid forcing automatically opening outputs view

Impact of Change

  • Users: Less frequent information messages, same information contained in extension output channel. Outputs view no longer automatically opens for certain errors.
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added VSCode Issues or PRs specific to VS Code extension risk:low Low risk change with minimal impact labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: chore(vscode): Move information messages to logs, prevent automatically opening outputs view
  • Issue: None. The title is clear, scoped, and accurately describes the change.
  • Recommendation: No change needed.

Commit Type

  • Properly selected (chore).
  • Only one commit type is selected, which is correct.

Risk Level

  • The selected label/body risk level is Low, and that matches the scope of the diff.
  • Advised risk remains low; I do not recommend raising it.

What & Why

  • Current:
    • Move several information messages to output channel logs to reduce clutter
    • Similarly, avoid forcing automatically opening outputs view
  • Issue: None. This is concise and explains both the change and motivation.
  • Recommendation: No change needed.

Impact of Change

  • The impact is described clearly enough for a chore-style PR.
  • Recommendation:
    • Users: Good as written.
    • Developers: N/A is acceptable.
    • System: N/A is acceptable.

⚠️ Test Plan

  • The PR body does not mark any test checkbox, but the diff includes multiple test updates/removals and this is primarily a message/logging refactor.
  • Because the change is code-affecting, it would be better to explicitly check Unit tests added/updated or add a short manual-testing note.
  • Recommendation: Mark the test plan item that applies best, for example:
    • - [x] Unit tests added/updated
    • or - [x] Manual testing completed with a short note if automation is not sufficient.

Contributors

  • @andrew-eldridge is listed.
  • No issues here.

⚠️ Screenshots/Videos

  • No screenshots are included, which is fine for a non-visual change.
  • No action required.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan ⚠️ Mark the appropriate test checkbox or add a short manual-testing note
Contributors None
Screenshots/Videos None

Overall: this PR passes. The only improvement I recommend is updating the Test Plan section so it reflects the test updates shown in the diff.


Last updated: Tue, 07 Jul 2026 05:14:37 GMT

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: chore(vscode): Move information messages to logs, prevent automatically opening outputs view
  • Issue: None. The title is descriptive, scoped, and clearly communicates the behavior change.
  • Recommendation: No changes needed.

Commit Type

  • Properly selected (chore).
  • Only one commit type is selected, which is correct.

Risk Level

  • The selected label/body risk level is Low, and that matches the diff well. No mismatch found.

What & Why

  • Current:
    • Move several information messages to output channel logs to reduce clutter
    • Similarly, avoid forcing automatically opening outputs view
  • Issue: None. This is brief but clear and aligned with the code changes.
  • Recommendation: No changes needed.

Impact of Change

  • Impact is described clearly enough for a chore/UX-oriented PR.
  • Recommendation:
    • Users: Good as written.
    • Developers: N/A is acceptable here.
    • System: N/A is acceptable here.

⚠️ Test Plan

  • There are test updates in the diff, so the test plan is effectively supported.
  • However, the PR body has the test checkboxes unchecked. Based on the diff, you should mark Unit tests added/updated as checked.
  • Recommendation: Update the PR body to check - [x] Unit tests added/updated.

Contributors

  • Present and acceptable.
  • No action required.

⚠️ Screenshots/Videos

  • Not required for this change because it is not a visual UI change in the usual sense.
  • No action required.

Summary Table

Section Status Recommendation
Title No changes needed
Commit Type Correctly selected
Risk Level Matches the diff
What & Why No changes needed
Impact of Change No changes needed
Test Plan ⚠️ Check Unit tests added/updated in the PR body
Contributors No changes needed
Screenshots/Videos No action needed

This PR passes. I did not advise a higher risk level than submitted; low is appropriate for the scope of the change. Please update the Test Plan checkbox in the PR body to reflect the unit test updates present in the diff.


Last updated: Tue, 07 Jul 2026 01:03:25 GMT

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

apps/vs-code-designer/src/app/commands/dataMapper/DataMapperPanel.ts - 0% covered
apps/vs-code-designer/src/app/commands/dataMapper/FxWorkflowRuntime.ts - 0% covered
apps/vs-code-designer/src/app/commands/deploy/notifyDeployComplete.ts - 0% covered
apps/vs-code-designer/src/app/commands/initProjectForVSCode/initProjectForVSCode.ts - 0% covered
apps/vs-code-designer/src/app/commands/workflows/configureWebhookRedirectEndpoint/configureWebhookRedirectEndpointSteps/ConfigureRedirectEndpointStep.ts - 0% covered
apps/vs-code-designer/src/app/commands/workflows/switchDebugMode/switchDebugMode.ts - 0% covered
apps/vs-code-designer/src/app/commands/workflows/unitTest/codefulUnitTest/createUnitTestFromRun.ts - 0% covered
apps/vs-code-designer/src/app/commands/workflows/unitTest/codelessUnitTest/editUnitTest.ts - 0% covered
apps/vs-code-designer/src/app/commands/workflows/useSQLStorage.ts - 0% covered
apps/vs-code-designer/src/app/utils/azurite/activateAzurite.ts - 0% covered
apps/vs-code-designer/src/app/utils/taskUtils.ts - 0% covered

⚠️ apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts - 75% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/commands/parameterizeConnections.ts - 58% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts - 70% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/commands/workflows/unitTest/codefulUnitTest/createUnitTest.ts - 64% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/cloudToLocalUtils.ts - 10% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/codeless/connection.ts - 1% covered (needs improvement)

Please add tests for the uncovered files before merging.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces VS Code notification noise in the Logic Apps VS Code designer extension by moving many informational toasts into the extension output channel and by removing the behavior that auto-opens the Output view on log writes.

Changes:

  • Removed ext.log/showInformation/showWarning/logTelemetry helpers and updated call sites to write to ext.outputChannel instead of showing information toasts.
  • Updated multiple workflow/project commands to log success/info to the output channel (and refactored a few control flows).
  • Updated/trimmed unit tests to stop asserting on information toasts; removed several test-coverage markdown summary files.

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
apps/vs-code-designer/src/extensionVariables.ts Removes auto-showing Output on log; simplifies ext helpers and error logging.
apps/vs-code-designer/src/app/utils/taskUtils.ts Removes redundant inline comments.
apps/vs-code-designer/src/app/utils/codeless/connection.ts Logs “Connection added” to output channel instead of showing an info toast.
apps/vs-code-designer/src/app/utils/cloudToLocalUtils.ts Logs import-related info to output channel; adjusts telemetry properties.
apps/vs-code-designer/src/app/utils/bundleFeed.ts Logs bundle-ready info to output channel instead of info toasts.
apps/vs-code-designer/src/app/utils/azurite/activateAzurite.ts Logs Azurite auto-start config info to output channel.
apps/vs-code-designer/src/app/utils/test/bundleFeed.test.ts Removes assertions tied to information toasts.
apps/vs-code-designer/src/app/languageServer/languageServer.ts Logs LSP debug-mode startup info to output channel (localized).
apps/vs-code-designer/src/app/commands/workflows/useSQLStorage.ts Logs SQL storage update info to output channel.
apps/vs-code-designer/src/app/commands/workflows/unitTest/codelessUnitTest/editUnitTest.ts Logs workspace-needed info to output channel.
apps/vs-code-designer/src/app/commands/workflows/unitTest/codefulUnitTest/createUnitTestFromRun.ts Logs unit-test creation success to output channel.
apps/vs-code-designer/src/app/commands/workflows/unitTest/codefulUnitTest/createUnitTest.ts Logs unit-test creation success to output channel (removes info toast).
apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts Logs conversion-related info to output channel instead of info toasts.
apps/vs-code-designer/src/app/commands/workflows/switchDebugMode/switchDebugMode.ts Refactors flow; logs success to output channel; adds explicit “no project” error.
apps/vs-code-designer/src/app/commands/workflows/exportLogicApp.ts Inlines telemetry property updates previously done via ext.logTelemetry.
apps/vs-code-designer/src/app/commands/workflows/enableAzureConnectors.ts Moves enabled messaging to output channel and refactors the early-return logic.
apps/vs-code-designer/src/app/commands/workflows/configureWebhookRedirectEndpoint/configureWebhookRedirectEndpointSteps/ConfigureRedirectEndpointStep.ts Logs success to output channel; changes failure handling to warning toast with error detail.
apps/vs-code-designer/src/app/commands/workflows/test/switchToDotnetProject.test.ts Updates extensionVariables mock; removes info-toast assertions/tests.
apps/vs-code-designer/src/app/commands/workflows/test/enableAzureConnectors.test.ts Removes info-toast assertions.
apps/vs-code-designer/src/app/commands/parameterizeConnections.ts Logs “already parameterized” info to output channel.
apps/vs-code-designer/src/app/commands/nodeJs/validateNodeJsIsLatest.ts Logs Node.js update completion to output channel.
apps/vs-code-designer/src/app/commands/nodeJs/test/validateNodeJsIsLatest.test.ts Removes info-toast assertion.
apps/vs-code-designer/src/app/commands/initProjectForVSCode/initProjectForVSCode.ts Logs initialization completion to output channel.
apps/vs-code-designer/src/app/commands/deploy/notifyDeployComplete.ts Removes redundant hybrid-only info toast; keeps interactive post-deploy prompt.
apps/vs-code-designer/src/app/commands/dataMapper/FxWorkflowRuntime.ts Uses output channel for runtime status logs (no Output auto-open).
apps/vs-code-designer/src/app/commands/dataMapper/DataMapperPanel.ts Removes reliance on deleted ext.showWarning/showInformation/log helpers.
apps/vs-code-designer/src/app/commands/createWorkflow/createLogicAppWorkflow.ts Logs workflow creation completion to output channel.
apps/vs-code-designer/src/app/commands/createWorkflow/test/createLogicAppWorkflow.test.ts Removes info-toast assertions.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts Logs project/workspace creation completion to output channel.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts Logs project creation completion to output channel.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/test/VSCODE_CONTENTS_TEST_COVERAGE.md Removes generated/summary coverage document.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/test/CreateLogicAppWorkspace.test.ts Removes info-toast assertions/tests.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/test/CreateLogicAppWorkspace_TEST_COVERAGE.md Removes generated/summary coverage document.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/test/CreateLogicAppProject.test.ts Removes info-toast assertion/test.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/test/CreateLogicAppProject_TEST_COVERAGE.md Removes generated/summary coverage document.
apps/vs-code-designer/src/app/commands/test/parameterizeConnections.test.ts Removes info-toast assertion.

Comment thread apps/vs-code-designer/src/app/commands/workflows/enableAzureConnectors.ts Outdated
Comment thread apps/vs-code-designer/src/app/commands/workflows/enableAzureConnectors.ts Outdated
Comment thread apps/vs-code-designer/src/app/commands/dataMapper/FxWorkflowRuntime.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants