Skip to content

chore(vscode): Move information messages to logs, prevent automatically opening outputs view #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-eldridge wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(vscode): Move information messages to logs, prevent automatically opening outputs view #9370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed8d93a
remove automatic open outputs view, remove redundant extension vars
andrew-eldridge Jul 6, 2026
19c0cbd
move information messages to logs
andrew-eldridge Jul 6, 2026
7332475
fix tests
andrew-eldridge Jul 7, 2026
953ae10
address pr comments
andrew-eldridge Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/vs-code-designer/src/app/commands/__test__/parameterizeConnections.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ describe('parameterizeConnections', () => {
it('should notify if all connections are already parameterized', async () => {
vi.spyOn(parameterizerUtil, 'areAllConnectionsParameterized').mockReturnValue(true);
await parameterizeConnections(testContext, testLogicAppProjectPath1);
expect(vscode.window.showInformationMessage).toHaveBeenCalledWith(
localizeUtil.localize('connectionsAlreadyParameterized', 'Connections are already parameterized.')
);
expect(parameterUtil.saveWorkflowParameter).not.toHaveBeenCalled();
});

Expand Down
3 changes: 2 additions & 1 deletion ...-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
updateWorkspaceFile,
} from './CreateLogicAppWorkspace';
import { devContainerFolderName, devContainerFileName } from '../../../../constants';
import { ext } from '../../../../extensionVariables';

export async function createLogicAppProject(context: IActionContext, options: any, workspaceRootFolder: any): Promise<void> {
addLocalFuncTelemetry(context);
Expand Down Expand Up @@ -90,7 +91,7 @@ export async function createLogicAppProject(context: IActionContext, options: an
const createFunctionAppFilesStep = new CreateFunctionAppFiles();
await createFunctionAppFilesStep.setup(mySubContext);
}
vscode.window.showInformationMessage(localize('finishedCreating', 'Finished creating project.'));
ext.outputChannel.appendLog(localize('finishedCreating', 'Finished creating project.'));
}

/**
Expand Down
6 changes: 3 additions & 3 deletions ...designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,13 +398,13 @@ export async function createLogicAppWorkspace(context: IActionContext, options:

if (fromPackage) {
await logicAppPackageProcessing(mySubContext);
vscode.window.showInformationMessage(localize('finishedExtractingPackage', 'Finished extracting package into a logic app workspace.'));
ext.outputChannel.appendLog(localize('finishedExtractingPackage', 'Finished extracting package into a logic app workspace.'));
} else {
if (webviewProjectContext.logicAppType === ProjectType.customCode || webviewProjectContext.logicAppType === ProjectType.rulesEngine) {
const createFunctionAppFilesStep = new CreateFunctionAppFiles();
await createFunctionAppFilesStep.setup(mySubContext);
}
vscode.window.showInformationMessage(localize('finishedCreating', 'Finished creating project.'));
ext.outputChannel.appendLog(localize('finishedCreating', 'Finished creating project.'));
}

await vscode.commands.executeCommand(extensionCommand.vscodeOpenFolder, vscode.Uri.file(workspaceFilePath), true /* forceNewWindow */);
Expand Down Expand Up @@ -474,5 +474,5 @@ export async function createLogicAppProject(context: IActionContext, options: an
const createFunctionAppFilesStep = new CreateFunctionAppFiles();
await createFunctionAppFilesStep.setup(mySubContext);
}
vscode.window.showInformationMessage(localize('finishedCreating', 'Finished creating project.'));
ext.outputChannel.appendLog(localize('finishedCreating', 'Finished creating project.'));
}
6 changes: 0 additions & 6 deletions .../app/commands/createNewCodeProject/CodeProjectBase/__test__/CreateLogicAppProject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,6 @@ describe('createLogicAppProject', () => {
expect(mockSetup).not.toHaveBeenCalled();
});

it('should show success message after project creation', async () => {
await createLogicAppProject(mockContext, mockOptions, workspaceRootFolder);

expect(vscode.window.showInformationMessage).toHaveBeenCalledWith(expect.stringContaining('Finished creating project'));
});

it('should set shouldCreateLogicAppProject to false when logic app exists', async () => {
// Create a valid logic app structure with proper workflow.json schema
await fse.ensureDir(logicAppFolderPath);
Expand Down
Loading
Loading