refactor: clients section to dynamically fetch from sunshine.json#5380
Open
eduardomozart wants to merge 3 commits into
Open
refactor: clients section to dynamically fetch from sunshine.json#5380eduardomozart wants to merge 3 commits into
eduardomozart wants to merge 3 commits into
Conversation
21 tasks
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
I will wait to run CI as there is an ongoing issue with sonar at the moment. https://community.sonarsource.com/t/sonar-seems-to-now-be-including-submodules-when-scanning-please-revert/184681
Could you also update the featured apps section in the web-ui to use the download images (like for Microsoft Store and Apple Store) when available?
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
gh-pages-templateto dynamically fetch client information from the centralizedsunshine.jsondirectory rather than relying on a staticclients.ymlfile.gh-pages-template/_data/clients.ymlas its static data is no longer necessary.gh-pages-template/index.htmlto fetchhttps://app.lizardbyte.dev/app-directory/sunshine.jsonand build the client DOM dynamically using JavaScript.sunshine.jsonschema.Note: This PR requires LizardByte/app-directory#40 to be merged first, as it relies on the newly defined
iconsanddownloadsschema insunshine.json.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage