nix-prefetch-git: disable maintenance mode via environment variables#525255
Merged
HeitorAugustoLN merged 1 commit intoJun 4, 2026
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
The commit 011471c ("fetchgit: disable git maintenance") disabled git's maintenance mode, but that does not affect git repositories with submodules. Switch to using the GIT_CONFIG_* environment variables. This is done in a way to make the approach more generic, but also kinda not the best ("insane") so that it works with any future change, even with `impureEnvVars`. Maybe `git -c maintenance.auto=false` can work but I cannot figure out how to use that here. I would prefer disabling maintenance mode in Git's derivation itself but did not find any build-time knob to toggle that.
thefossguy
force-pushed
the
nix-prefetch-git-propagate-disabling-maintenance-mode
branch
from
7f21e88 to
88cfc54
Compare
Member
Author
|
I realized that I overlooked the commit message about making |
nixpkgs-ci
Bot
added
the
12.approvals: 1
Member
Author
|
Member
Author
|
Member
Author
|
Huh, 2 packages were not automatically detected on |
Member
Author
|
Member
Author
|
philiptaron
approved these changes
May 28, 2026
philiptaron
left a comment
philiptaron
left a comment
Contributor
There was a problem hiding this comment.
Sure. Looking to @me-and to ✅ also before merge
nixpkgs-ci
Bot
added
12.approvals: 2
Member
|
a-kenji
approved these changes
May 29, 2026
nixpkgs-ci
Bot
added
12.approvals: 3+
Member
|
I'll try to review before the end of the weekend. I'm slightly surprised I didn't hit this problem when I made this fix, as the test repo I was using absolutely had submodules! Without yet having looked at the code, a possible alternative to |
4 tasks
Member
Author
I've noticed this inconsistency too. In #524670, we're trying to bump the version for packages of the COSMIC DE and only one package (
I don't have a strong opinion on this. I'm happy to refactor this PR if that's what you want. |
alyssais
approved these changes
May 31, 2026
me-and
approved these changes
May 31, 2026
me-and
left a comment
me-and
left a comment
Member
There was a problem hiding this comment.
LGTM! I'd honestly expected something much more horrendous before I went looking at the code.
Thank you!
Sirius902
added a commit
to Sirius902/nixos-config
that referenced
this pull request
May 31, 2026
NixOS/nixpkgs#524430 only disabled maintenance.auto in the top-level repo's local config; submodule clones spawned by postCheckout still raced. NixOS/nixpkgs#525255 switches to env vars that propagate into submodule subprocesses. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
Author
|
Could someone with commit access merge this PR? |
phanirithvij
added
backport release-26.05
Contributor
|
Successfully created backport PR for |
github-actions
Bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 011471c ("fetchgit: disable git maintenance") disabled
git's maintenance mode, but that does not affect git repositories with
submodules.
Switch to using the GIT_CONFIG_* environment variables. This is done in
a way to make the approach more generic, but also kinda not the best
("insane") so that it works with any future change, even with
impureEnvVars.Maybe
git -c maintenance.auto=falsecan work but I cannot figure outhow to use that here. I would prefer disabling maintenance mode in Git's
derivation itself but did not find any build-time knob to toggle that.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.