Skip to content

[Backport release-26.05] nix-prefetch-git: disable maintenance mode via environment variables#531122

Merged
philiptaron merged 1 commit into
release-26.05from
backport-525255-to-release-26.05
Jun 12, 2026
Merged

[Backport release-26.05] nix-prefetch-git: disable maintenance mode via environment variables#531122
philiptaron merged 1 commit into
release-26.05from
backport-525255-to-release-26.05

Conversation

@nixpkgs-ci

@nixpkgs-ci nixpkgs-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Bot-based backport to release-26.05, triggered by a label in #525255.

Before merging, ensure that this backport is acceptable for the release.

Even as a non-committer, if you find that it is not acceptable, leave a comment.

Tip

If you maintain all packages touched by this pull request, and they are all located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this PR using the nixpkgs-merge-bot.

The commit 011471c ("fetchgit: disable git maintenance") disabled
git's maintenance mode, but that does not affect git repositories with
submodules.

Switch to using the GIT_CONFIG_* environment variables. This is done in
a way to make the approach more generic, but also kinda not the best
("insane") so that it works with any future change, even with
`impureEnvVars`.

Maybe `git -c maintenance.auto=false` can work but I cannot figure out
how to use that here. I would prefer disabling maintenance mode in Git's
derivation itself but did not find any build-time knob to toggle that.

(cherry picked from commit 88cfc54)
@nixpkgs-ci nixpkgs-ci Bot requested a review from thefossguy June 12, 2026 19:22
@nixpkgs-ci nixpkgs-ci Bot requested a review from philiptaron June 12, 2026 19:27
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 4.workflow: backport This targets a stable branch labels Jun 12, 2026
@phanirithvij phanirithvij requested a review from me-and June 12, 2026 20:30
@phanirithvij

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha (5f60c00)

Command: nixpkgs-review pr 531122
Commit: 0c646e3ab595902d8e141ebbec4b59bdc2151eee (subsequent changes)
Merge: e363c6cafc31bf2f48423e25adb3a8da26c010b9

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/27443165001/attempts/1


x86_64-linux

✅ 71 packages built:
  • bundix
  • cabal2nix
  • crate2nix
  • crystal2nix
  • dub-to-nix
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.nix-thunk
  • haskellPackages.nvfetcher
  • haskellPackages.update-nix-fetchgit
  • lidarr
  • lixPackageSets.git.nix-update
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_95.nix-update)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lon
  • luarocks-packages-updater
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nixtamal
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python313Packages.nixpkgs-updaters-library
  • python314Packages.nixpkgs-updaters-library
  • radarr
  • sonarr
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.haskell.cabalSdist.assumptionLocalHasDirectReference
  • tests.haskell.cabalSdist.localHasNoDirectReference
  • tests.pnpm.pnpm-fixup-state-db
  • tests.pnpm.pnpm_11_v3
  • tests.pnpm.pnpm_11_v4
  • tests.prefer-remote-fetch.fetchgit
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPluginsUpdater

aarch64-linux

✅ 69 packages built:
  • bundix
  • cabal2nix
  • crate2nix
  • crystal2nix
  • dub-to-nix
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.nix-thunk
  • haskellPackages.nvfetcher
  • haskellPackages.update-nix-fetchgit
  • lidarr
  • lixPackageSets.git.nix-update
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_95.nix-update)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lon
  • luarocks-packages-updater
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nixtamal
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python313Packages.nixpkgs-updaters-library
  • python314Packages.nixpkgs-updaters-library
  • radarr
  • sonarr
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.pnpm.pnpm-fixup-state-db
  • tests.pnpm.pnpm_11_v3
  • tests.pnpm.pnpm_11_v4
  • tests.prefer-remote-fetch.fetchgit
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPluginsUpdater

x86_64-darwin (sandbox = relaxed)

❌ 5 packages failed to build:
  • lidarr
  • radarr
  • sonarr
  • tests.pnpm.pnpm_11_v3
  • tests.pnpm.pnpm_11_v4
✅ 64 packages built:
  • bundix
  • cabal2nix
  • crate2nix
  • crystal2nix
  • dub-to-nix
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.nix-thunk
  • haskellPackages.nvfetcher
  • haskellPackages.update-nix-fetchgit
  • lixPackageSets.git.nix-update
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_95.nix-update)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lon
  • luarocks-packages-updater
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nixtamal
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python313Packages.nixpkgs-updaters-library
  • python314Packages.nixpkgs-updaters-library
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.pnpm.pnpm-fixup-state-db
  • tests.prefer-remote-fetch.fetchgit
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPluginsUpdater

aarch64-darwin (sandbox = relaxed)

❌ 6 packages failed to build:
  • lidarr
  • radarr
  • sonarr
  • tests.fetchFromGitHub.rootDir
  • tests.fetchgit.dumb-http-signed-tag
  • tests.pnpm.pnpm_11_v3
✅ 63 packages built:
  • bundix
  • cabal2nix
  • crate2nix
  • crystal2nix
  • dub-to-nix
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.nix-thunk
  • haskellPackages.nvfetcher
  • haskellPackages.update-nix-fetchgit
  • lixPackageSets.git.nix-update
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_95.nix-update)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lon
  • luarocks-packages-updater
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nixtamal
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python313Packages.nixpkgs-updaters-library
  • python314Packages.nixpkgs-updaters-library
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.pnpm.pnpm-fixup-state-db
  • tests.pnpm.pnpm_11_v4
  • tests.prefer-remote-fetch.fetchgit
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPluginsUpdater

@philiptaron philiptaron added this pull request to the merge queue Jun 12, 2026
Merged via the queue into release-26.05 with commit 12602a2 Jun 12, 2026
31 checks passed
@philiptaron philiptaron deleted the backport-525255-to-release-26.05 branch June 12, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants