fix(tools): reject non-positive CallROS2ServiceTool timeout_sec

src/rai_core/rai/tools/ros2/generic/services.py

@@ -20,6 +20,7 @@
 
 from rai.communication.ros2 import ROS2Message
 from rai.tools.ros2.base import BaseROS2Tool, BaseROS2Toolkit
+from rai.tools.timeout import require_positive_timeout
 
 
 class ROS2ServicesToolkit(BaseROS2Toolkit):
@@ -109,6 +110,7 @@ def _run(
     ) -> str:
         if not self.is_writable(service_name):
             raise ValueError(f"Service {service_name} is not writable")
+        timeout_sec = require_positive_timeout(timeout_sec)
         if service_args is None:
             service_args = {}
         message = ROS2Message(payload=service_args)

src/rai_core/rai/tools/timeout.py

@@ -159,3 +159,23 @@ def wrapper(self, *args, **kwargs):
         return wrapper
 
     return decorator
+
+
+def require_positive_timeout(timeout_sec: object, *, name: str = "timeout_sec") -> float:
+    """Validate timeout is a real positive number (bool rejected).
+
+    Returns the value as float. Raises ValueError on invalid input.
+    """
+    if timeout_sec is True or timeout_sec is False:
+        raise ValueError(f"{name} must be a positive number")
+    if isinstance(timeout_sec, int) and not isinstance(timeout_sec, bool):
+        value = float(timeout_sec)
+    elif isinstance(timeout_sec, float):
+        value = float(timeout_sec)
+    else:
+        raise ValueError(f"{name} must be a positive number")
+    if value != value:  # NaN
+        raise ValueError(f"{name} must be a positive number")
+    if value <= 0:
+        raise ValueError(f"{name} must be positive")
+    return value

tests/tools/test_require_positive_timeout.py

@@ -0,0 +1,30 @@
+# Copyright (C) 2026 Robotec.AI
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import math
+
+import pytest
+
+from rai.tools.timeout import require_positive_timeout
+
+
+@pytest.mark.parametrize("value", [0, -1, -0.01, True, False, "1", None, math.nan, object()])
+def test_require_positive_timeout_rejects_invalid(value):
+    with pytest.raises(ValueError, match="timeout"):
+        require_positive_timeout(value)
+
+
+@pytest.mark.parametrize("value,expected", [(1, 1.0), (0.5, 0.5), (2, 2.0)])
+def test_require_positive_timeout_accepts_positive(value, expected):
+    assert require_positive_timeout(value) == expected