Skip to content

commit queue after block accepted#1105

Merged
Rexagon merged 2 commits into
masterfrom
fix/commit-queue-after-block-accepted
Jun 26, 2026
Merged

commit queue after block accepted#1105
Rexagon merged 2 commits into
masterfrom
fix/commit-queue-after-block-accepted

Conversation

@SmaGMan

@SmaGMan SmaGMan commented Jun 25, 2026

Copy link
Copy Markdown
Member

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Fully compatible

SPECIAL DEPLOYMENT ACTIONS

[Not Required]


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

[No special coverage]

Network Tests

[No coverage]

Manual Tests

Manual tests used:

  • apply hack to stop node after mc block 20 is accepted
  • set low block gas limit to 8_000_000
  • started local network on 3 nodes
  • start transactions test
  • wait until nodes stop
  • disable hack and restart nodes
  • they should rollback queue and continue collation

@github-actions

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1105

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1105
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1105 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.63%. Comparing base (43a3979) to head (c1316e2).

Files with missing lines Patch % Lines
collator/src/manager/commit.rs 45.00% 8 Missing and 3 partials ⚠️
cli/src/node/mod.rs 0.00% 7 Missing ⚠️
collator/src/manager/mod.rs 81.81% 1 Missing and 1 partial ⚠️
collator/src/internal_queue/state/storage.rs 66.66% 0 Missing and 1 partial ⚠️
collator/src/manager/types.rs 83.33% 0 Missing and 1 partial ⚠️
collator/src/state_node.rs 95.45% 1 Missing ⚠️
collator/src/types.rs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1105   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files         484      484           
  Lines       82583    82502   -81     
  Branches    82583    82502   -81     
=======================================
- Hits        49250    49203   -47     
+ Misses      30991    30964   -27     
+ Partials     2342     2335    -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SmaGMan SmaGMan requested review from Mododo and Rexagon June 26, 2026 16:03
@Rexagon

Rexagon commented Jun 26, 2026

Copy link
Copy Markdown
Member

Note: discussed that a follow-up PR is required to sync the queue commit with the mc block commit

@Mododo Mododo force-pushed the fix/commit-queue-after-block-accepted branch from 9dcf204 to c1316e2 Compare June 26, 2026 16:06

@Mododo Mododo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtllm

@Rexagon Rexagon added this pull request to the merge queue Jun 26, 2026
Merged via the queue into master with commit 45bbd2a Jun 26, 2026
23 checks passed
@Rexagon Rexagon deleted the fix/commit-queue-after-block-accepted branch June 26, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants