Use AsyncTask thread-safe logging helpers in MavenDownload#12024
Merged
Conversation
6 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix use of thread-safe AsyncTask logging in MavenDownload task
Use AsyncTask thread-safe logging helpers in MavenDownload
Jul 9, 2026
jonathanpeppers
approved these changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MavenDownload MSBuild task (which derives from AsyncTask) to use AsyncTask’s thread-safe logging helper methods instead of calling TaskLoggingHelper.Log* directly from async/background execution paths.
Changes:
- Replaced
Log.LogMessage(...)withLogMessage(...)at three call sites. - Replaced
Log.LogCodedError(...)withLogCodedError(...)at three call sites.
| return null; | ||
|
|
||
| Log.LogMessage ("Found library '{0}' for Java artifact '{1}'.", artifact_file, artifact); | ||
| LogMessage ("Found library '{0}' for Java artifact '{1}'.", artifact_file, artifact); |
simonrozsival
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MavenDownloadderives fromAsyncTaskbut still used six directLog.Log*calls inside async/background execution paths. This updates those call sites toAsyncTask’s thread-safe logging helpers while preserving existing messages and XA error codes.Logging API alignment in
MavenDownloadLog.LogMessage(...)→LogMessage(...)(3 sites)Log.LogCodedError(...)→LogCodedError(...)(3 sites)XA4237/XA4252/XA4239values remain unchanged.Scope intentionally constrained
Logusages passed as an argument to helper APIs unchanged (GetRequiredMetadata,TryParseArtifactWithVersion,DownloadPayload), since those APIs requireTaskLoggingHelper.