Skip to content

Use AsyncTask thread-safe logging helpers in MavenDownload #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Jul 9, 2026
+6 −6
Merged

Use AsyncTask thread-safe logging helpers in MavenDownload #12024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a09b97
Initial plan
Copilot Jul 9, 2026
ac1d0b2
[tasks] use AsyncTask logging helpers in MavenDownload
Copilot Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Xamarin.Android.Build.Tasks/Tasks/MavenDownload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public async override System.Threading.Tasks.Task RunTaskAsync ()
if (artifact_file is null)
return null;

Log.LogMessage ("Found library '{0}' for Java artifact '{1}'.", artifact_file, artifact);
LogMessage ("Found library '{0}' for Java artifact '{1}'.", artifact_file, artifact);

var result = new TaskItem (artifact_file);

Expand All @@ -114,7 +114,7 @@ public async override System.Threading.Tasks.Task RunTaskAsync ()
var primary_pom = resolver.ResolvedPoms [artifact.VersionedArtifactString];
result.SetMetadata ("Manifest", primary_pom);

Log.LogMessage ("Found POM file '{0}' for Java artifact '{1}'.", primary_pom, artifact);
LogMessage ("Found POM file '{0}' for Java artifact '{1}'.", primary_pom, artifact);

// Create TaskItems for any other POMs we resolved
foreach (var kv in resolver.ResolvedPoms.Where (k => k.Key != artifact.VersionedArtifactString)) {
Expand All @@ -126,10 +126,10 @@ public async override System.Threading.Tasks.Task RunTaskAsync ()

additionalPoms.Add (pom_item);

Log.LogMessage ("Found POM file '{0}' for Java artifact '{1}'.", kv.Value, pom_artifact);
LogMessage ("Found POM file '{0}' for Java artifact '{1}'.", kv.Value, pom_artifact);
}
} catch (Exception ex) {
Log.LogCodedError ("XA4237", Properties.Resources.XA4237, artifact, ex.Unwrap ().Message);
LogCodedError ("XA4237", Properties.Resources.XA4237, artifact, ex.Unwrap ().Message);
return null;
}

Expand All @@ -150,7 +150,7 @@ public async override System.Threading.Tasks.Task RunTaskAsync ()
(uri.Scheme == Uri.UriSchemeHttp || uri.Scheme == Uri.UriSchemeHttps)) {
if (uri.Scheme == Uri.UriSchemeHttp &&
!string.Equals (item.GetMetadataOrDefault ("AllowInsecureHttp", "false"), "true", StringComparison.OrdinalIgnoreCase)) {
Log.LogCodedError ("XA4252", Properties.Resources.XA4252, type);
LogCodedError ("XA4252", Properties.Resources.XA4252, type);
return null;
}

Expand All @@ -162,7 +162,7 @@ public async override System.Threading.Tasks.Task RunTaskAsync ()
}

if (repo is null)
Log.LogCodedError ("XA4239", Properties.Resources.XA4239, type);
LogCodedError ("XA4239", Properties.Resources.XA4239, type);

return repo is not null ? new CachedMavenRepository (MavenCacheDirectory, repo) : null;
}
Expand Down
Loading